ApexGuru Antipattern: Schema.getGlobalDescribe() Called Multiple Times Within a Class

Scope

Detection and recommendation

Detection Example

public void pro(String objectName) {
    
    // Get the describe result for the provided object name
    Schema.DescribeSObjectResult describeResult = Schema.getGlobalDescribe().get(objectName).getDescribe();
    
    // Log object label and plural label
    System.debug('Object Label: ' + describeResult.getLabel());
    System.debug('Object Plural Label: ' + describeResult.getLabelPlural());

    // Dynamically create a new instance of the SObject
    SObject newRecord = Schema.getGlobalDescribe().get(objectName).newSObject();
    
    newRecord.put('Name', 'Address');
    
    // Insert the record
    insert newRecord;
    
    // Log the newly created record ID
    System.debug('New record created with ID: ' + newRecord.Id);
}
}

Recommendation

When you optimize logic design, avoid multiple Schema.getGlobalDescribe() calls. Focus on optimizing the functionality itself. Use alternatives like caching or metadata to eliminate the need for these calls. Retrieve schema information one time at the start of the method and reuse it to improve performance.

public void getObjectDescribe(String objectName) {    
    // Get the describe result for the provided object name
    Schema.DescribeSObjectResult describeResult = null
    try {
         List<Schema.DescribeSObjectResult> describes = Schema.describeSObjects(new String[] { objName}, SObjectDescribeOptions.DEFERRED);
         result = describes[0];
     } catch (InvalidParameterValueException ipve) {
          result = null;
     }
     Schema.DescribeSObjectResult objectResult = result;
    
    // Log object label and plural label
    
    if (objectResult != null) {
        System.debug('Object Label: ' + describeResult.getLabel());
        System.debug('Object Plural Label: ' + describeResult.getLabelPlural());
    }

    // Dynamically create a new instance of the SObject
    SObject newRecord = (SObject)Type.forName( objectName ).newInstance()
    
    newRecord.put('Name', 'Address');
    
    // Insert the record
    insert newRecord;
    
    // Log the newly created record ID
    System.debug('New record created with ID: ' + newRecord.Id);
}