ApexGuru Antipattern: Schema.getGlobalDescribe() In a Loop

Scope

Detection and recommendation

Detection Example

apex
public class ObjectMetadataHandler {
    
    public void processObjectNames(List<String> objectNames) {
        for (String objectName : objectNames) {
            if (Schema.getGlobalDescribe().containsKey(objectName)) {
                Schema.SObjectType sObjectType = objectMap.get(objectName);
                System.debug('Object found: ' + objectName);
            } else {
                System.debug('Object not found: ' + objectName);
            }
        }
    }
}

Recommendation

Cache the results of Schema.getGlobalDescribe() outside of the loop and reuse them within the loop.

public class ObjectMetadataHandler {
    // Cache the result of Schema.getGlobalDescribe() to avoid redundant calls
    private static Map<String, Schema.SObjectType> objectMap = Schema.getGlobalDescribe();

    public void processObjectNames(List<String> objectNames) {
        for (String objectName : objectNames) {
            // Use the cached objectMap to access SObjectType
            if (objectMap.containsKey(objectName)) {
                Schema.SObjectType sObjectType = objectMap.get(objectName);
                System.debug('Object found: ' + objectName);
            } else {
                System.debug('Object not found: ' + objectName);
            }
        }
    }
}